Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modules pullreq #11

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Remove modules pullreq #11

merged 2 commits into from
Jul 31, 2024

Conversation

vincentmarchetti
Copy link

The action proposed in issue 10: #10

The compilation products are not needed anymore.
They can be built on local systems through npm run build script
or deployed from npm @iiif/3d-manifesto-dev
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@gjcope gjcope self-requested a review July 31, 2024 16:13
Copy link

@gjcope gjcope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We may want to still include built modules in a GitHub release.

@gjcope gjcope merged commit 29029e8 into master Jul 31, 2024
2 checks passed
@glenrobson glenrobson deleted the remove-modules-pullreq branch July 31, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants