Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider has the wrong type (Normalized) #2

Open
stephenwf opened this issue Apr 27, 2022 · 1 comment
Open

Provider has the wrong type (Normalized) #2

stephenwf opened this issue Apr 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@stephenwf
Copy link
Member

The reference here was not updated after changing to Provider in IIIF-Commons/presentation-3-types#2
https://github.com/IIIF-Commons/presentation-3-types/blob/main/iiif/descriptive.d.ts#L191
cc @jbaiter
@stephenwf stephenwf added the bug Something isn't working label Apr 27, 2022
@stephenwf
Copy link
Member Author

stephenwf commented Apr 27, 2022 •
edited
Loading

Related to: IIIF-Commons/parser#4
Which looks like Agent is correct, and Provider might be wrong.

Could be a Vault bug in inferring what Referece<'Agent'> resolves to.

edit: I think this is just confusing naming
https://github.com/IIIF-Commons/vault/blob/0bc160857d768036a66099d272d947d63a4d2a7d/src/types.ts#L77-L80

With Agent / ResourceProvider being used interchangeably.

@stephenwf stephenwf transferred this issue from IIIF-Commons/presentation-3-types Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephenwf