Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix awful shared/ folder #6

Open
benkeen opened this issue Apr 4, 2023 · 4 comments
Open

Fix awful shared/ folder #6

benkeen opened this issue Apr 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@benkeen
Copy link
Member

benkeen commented Apr 4, 2023

I recall running into plenty of problems here, so vouched for the simplest solution. But it sucks! Should be in a separate package or something. The grunt copy thing is awful.

@amb26
Copy link
Member

amb26 commented Apr 5, 2023

I did wonder about that - is the grunt shared copy part of an idiom from somewhere? Would you be able to run down some of the problems you ran into since I'd like to get a sense of the design tensions here.

@benkeen
Copy link
Member Author

benkeen commented Apr 6, 2023

I'll have time this weekend to give this thing a look over. This one was really intractable though, I just don't recall the problems. Storing this as a separate internal package is obviously the logical arrangement so I'm sure I had a good reason (right? Right?).

@benkeen benkeen added the enhancement New feature or request label Apr 9, 2023
@benkeen
Copy link
Member Author

benkeen commented Apr 16, 2023

This is a really fussy one. I'm using rollup and the @rollup/plugin-typescript plugin to generate the bundle for @imerss/inat-components. Normally with TS you'd just use project references to import the code from that shared location, but it doesn't appear to be supported by the rollup plugin, as described here. I get the exact same error.

I don't much want to ditch rollup, but perhaps I'll look into parcel or something else.

@benkeen
Copy link
Member Author

benkeen commented Jun 12, 2023

Ugh. Going to try Parcel. This is becoming a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants