Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation function continued #224

Closed
jhnnsnk opened this issue Aug 15, 2024 · 2 comments · Fixed by #225
Closed

Correlation function continued #224

jhnnsnk opened this issue Aug 15, 2024 · 2 comments · Fixed by #225

Comments

@jhnnsnk
Copy link
Collaborator

jhnnsnk commented Aug 15, 2024

As a follow-up to #223, double check time lags and scaling of cross-correlation functions.

@espenhgn
Copy link
Collaborator

espenhgn commented Aug 15, 2024

Hi @jhnnsnk ,
On this line: https://github.com/INM-6/mesocircuit-model/blob/ed1baa417f926e4596eb9a121b04f413ba5a779c/scripts/ms_figures_cross_correlation_function.py#L138C55-L138C62
the code does not account for the downsampling factor q, as lags=25 I assume must be in units of ms, while the output of ss.correlation_lags is in units of dt.

@jhnnsnk
Copy link
Collaborator Author

jhnnsnk commented Aug 15, 2024

Well spotted @espenhgn! #225 converts the lags into time units (ms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants