Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert_legacyEmuDB_to_emuDB() should check duplicate label entries in .tpl #59

Open
raphywink opened this issue Oct 14, 2015 · 0 comments
Assignees

Comments

@raphywink
Copy link

Just had the case of following bad entries in a legacyEmuDB .tpl file:

! label types at each level
label Word Word
label Phonemes Phonemes
label Targets Targets

The conversion works but produces a broken DBconfigJSON:

...
  {
      "name": "Targets",
      "type": "EVENT",
      "attributeDefinitions": [
        {
          "name": "Targets",
          "type": "STRING",
          "labelGroups": [
            {
              "name": "are",
              "values": [
                "first",
                "second"
              ]
            }
          ]
        },
        {
          "name": "Targets", <- SIC! duplicate attributeDefinitions$name entry
          "type": "STRING"
        }
      ]
    }
...

convert_legacyEmuDB_to_emuDB() should probably throw an error if it encounters these bad entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants