Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIFI Cryomag: Gaussmeter IOC (Lakeshore LS460) #646

Closed
kjwoodsISIS opened this issue Feb 24, 2016 · 15 comments
Closed

HIFI Cryomag: Gaussmeter IOC (Lakeshore LS460) #646

kjwoodsISIS opened this issue Feb 24, 2016 · 15 comments

Comments

@kjwoodsISIS
Copy link
Contributor

kjwoodsISIS commented Feb 24, 2016

As a support person I want the cryomag on NDXHIFI to be robust and maintainable, rewriting the Gaussmeter will improve that module of code

Acceptance Criteria

  1. Write an IOC for communicating with a Lakeshore LS460 Gaussmeter (needed in other places eventually)
  2. Write an emulator for the LS460
  3. Write the IOC test framework for the LS460
  4. Create an OPI for the LS460

Notes

  1. This will be a standard stream/asyn driver
  2. There is a copy of the manual in http://www.facilities.rl.ac.uk/isis/projects/ts1/HIFICryomagnetSoftwareImprovement/Manuals/Forms/AllItems.aspx
@kjwoodsISIS
Copy link
Contributor Author

Imported from trac issue 647. Created by kvlb23 on 2015-02-06T11:47:30, last modified: 2015-02-06T13:20:52

@KathrynBaker
Copy link
Member

Original ticket content:

As a support person I want the cryomag on NDXHIFI to be robust and maintainable, rewriting the Gaussmeter will improve that module of code

Acceptance Criteria

  1. Write an IOC for communicating with a Lakeshore LS460 Gaussmeter (needed in other places eventually)
  2. Alter the existing LabVIEW code to reference the IOC

Notes

  1. The existing GUI interface should be maintained until all changes are complete, although the code underneath should be updated to use the PVs from the IOC
  2. When altering the LabVIEW GUIs care should be taken over the existence of hidden datasocket links
  3. The lvDCOM IOC referring to the DS and EI VI will need to have the PVs now being generated from an IOC removed from it's listing

@KathrynBaker KathrynBaker changed the title HIFI Cryomag: Gaussmeter Code replace HIFI Cryomag: Gaussmeter IOC (Lakeshore LS460) Jul 19, 2017
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2017_07_27 milestone Jul 27, 2017
@mukeez mukeez added review and removed in progress labels Aug 11, 2017
@samueljackson92
Copy link

This still needs some work. The issues I found are as follows:

  • The new Lakeshore460 support folder was missing in from the .gitmodules file in the EPICS repo. I've added it for you on a branch called Ticket646_Lakeshore460.

  • I'm confused as to which DB file should be used? The one in EPICS/ioc or EPICS/support/lakeshore460? One of them needs to be removed in favor of the other and the build needs to be updated accordingly.

  • The DB file needs simulation records adding to it. You can read all about this here

  • The device emulator PR has a few python errors that prevent the emulator from running. There's also a few style comments to fix while you're there.

  • The IOC test framework PR has a merge conflict that needs resolving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests