Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genie_python: review obsolete packages #6531

Closed
FreddieAkeroyd opened this issue May 21, 2021 · 8 comments
Closed

genie_python: review obsolete packages #6531

FreddieAkeroyd opened this issue May 21, 2021 · 8 comments
Labels

Comments

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented May 21, 2021

Now support for python 2.7 has been dropped, we should review requirements.txt for any unnecessary additions as these can cause issues e.g. enum34 caused problems on python startup on ESS daq linux machine. Do we need backports, 2to3, six, ...

Acceptance criteria

  • Figure out what each requirement is used for
  • Unnecessary modules removed
  • It is obvious from the release notes what we have removed
@FreddieAkeroyd
Copy link
Member Author

Maybe do during #6370 ?

@rerpha
Copy link
Contributor

rerpha commented May 21, 2021

Was just about to suggest this!

@rerpha
Copy link
Contributor

rerpha commented May 21, 2021

Follows on from #6132

@DominicOram
Copy link
Contributor

As we do this we should try and document what each dependency is for and why it is there, probably jut as comments in the requirements.txt. I think we have got a lot of stuff in there that people have just thrown in.

@rerpha
Copy link
Contributor

rerpha commented May 24, 2021

As we do this we should try and document what each dependency is for and why it is there, probably jut as comments in the requirements.txt. I think we have got a lot of stuff in there that people have just thrown in.

or better yet, we make separate requirements.txts for each repository that requires special dependencies, even if they are stored in genie python itself. You can create requirements files with custom names and then include them in a parent requirements.txt like this - https://stackoverflow.com/questions/17803829/how-to-customize-a-requirements-txt-for-multiple-environments

@rerpha
Copy link
Contributor

rerpha commented May 24, 2021

so for example we have a bskafka-requirements.txt which means we can pull anything kafka and flatbuffers out of the main requirements.txt

@DominicOram
Copy link
Contributor

Yes, e.g. #5426

@DominicOram DominicOram added the bucket proposals that didn't make into the sprint label Jun 16, 2021
@DominicOram DominicOram added this to the SPRINT_2021_05_27 milestone Jun 16, 2021
@DominicOram DominicOram removed this from the SPRINT_2021_05_27 milestone Jun 17, 2021
@KathrynBaker KathrynBaker removed the bucket proposals that didn't make into the sprint label Jun 24, 2021
@Tom-Willemsen
Copy link
Contributor

Substantially similar issue in other repo. genie itself no longer has these requirements (or any others that it doesn't directly use)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants