Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling teNOR's optimisation passes #14

Open
ISSOtm opened this issue Mar 17, 2023 · 0 comments
Open

Allow disabling teNOR's optimisation passes #14

ISSOtm opened this issue Mar 17, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ISSOtm
Copy link
Owner

ISSOtm commented Mar 17, 2023

This should be relatively easy:

  1. Add a new option (in main.rs); I'm thinking something like -O -trim_patterns,+prune_instruments. (-O is a common "optimisation" flag, e.g. in C compilers.) The argument would be a comma-separated list of pass toggles, with the + or - prefix indicating whether to enable or disable the pass.
  2. For each pass, if it's disabled, then replace it with a dummy operation that doesn't perform any optimisations. (For example, the "row overlap" pass would instead return some arbitrary order, and no overlap.)

Rationale

This would be useful for people doing tricks with the song data (e.g. using routines to manipulate the song pointer).

@ISSOtm ISSOtm added enhancement New feature or request good first issue Good for newcomers labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant