Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering space as an execution key, requires a literal to be typed #25

Open
patrickberkeley opened this issue Jan 15, 2018 · 1 comment
Assignees

Comments

@patrickberkeley
Copy link
Member

It's weird to have the executionKey be whitespace:

keyManager.addMacro({
            executionKey: ' ', // <- weirdness
            keyEvent: 'keydown',
            callback: () => {
                console.log('spacebar');
            }
        })
@jordpo jordpo self-assigned this Jan 25, 2018
@jordpo
Copy link
Contributor

jordpo commented Jan 25, 2018

This would make more sense as space.

@gossi gossi mentioned this issue May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants