Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events and Incident History Improvements #157

Closed
nilmerg opened this issue Jan 18, 2024 · 5 comments · Fixed by #166
Closed

Events and Incident History Improvements #157

nilmerg opened this issue Jan 18, 2024 · 5 comments · Fixed by #166
Assignees
Labels
area/view Affects an entire view enhancement New feature or improvement
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Jan 18, 2024

Recent changes to icinga-notifications made internal events appear in the events listing. They are currently shown like this:

Events

image

Prerequisites

It is currently not possible to differentiate between internal events. The daemon needs to write them to the database in a way, this can happen: Icinga/icinga-notifications#162

Until the daemon is updated, the differentiation could temporarily happen based on the message.

Missing Visual

There should be an icon visible. The icon must be the same that's used by the Incident History. Scroll down for details

Incorrect Title

acknowledged is only the default phrase. For each type of event a new phrase should be added. At the moment, the phrase is identified based on the event severity. Since the severity was previously only missing for Acknowledge events sent by Icinga, the same phrase is used for internal events as well.

Incorrect Source Icon

Internal events have no source, the icon is only shown because they are tied to objects still and such have a source. The source icon must reflect that they are internal events emitted by icinga-notifications. There's no icon or logo for this yet. @flourish86 may have input on this.

Event Detail

image

Incorrect Header

Once the visualization in the events listing is changed, this should be automatically reflected here.

Missing Incident

This is an issue in icinga-notifications, as there's no entry in the incident_event table for internal events: Icinga/icinga-notifications#151

Source

This is again the source of the related object. The icon used should be the same as in the events listing for internal events and the label should just be Icinga Notifications.

Incident History

image

Object Name

The name of the object is redundant and doesn't need to be repeated on every severity change. Must be removed.

Visuals

Should use the new icons mentioned below.

Content

At the moment, source events are not shown. Only incident events. This should be extended so that source events are also visible, so that if a source event is listed, the incident events caused by it appear chronologically afterwards. (Yes, this means that the first severity!=ok event is the first, and incident opened the second.)

The list can grow very large, if an incident is open for a long time. We should limit the history shown in the detail to a definite number of rows. (e.g. 15) All history entries should only be listed in a separate tab which works the same as host/service history tabs in Icinga DB Web.

@nilmerg nilmerg added enhancement New feature or improvement area/view Affects an entire view labels Jan 18, 2024
@nilmerg nilmerg added this to the Preview #1 milestone Jan 18, 2024
@flourish86
Copy link
Contributor

flourish86 commented Feb 5, 2024

I listed the icons for the internal events here.

Frame 8

Also the internal events' appearance should be different from the status changes. In this example I made the external events' icons a little bigger. Please also note that the status icon shapes are contained in the FontAwesome icon glyphs, while the internal event visuals have a circular element applied on them.

Frame 14

Let me know, if you need css details for the updated styles.

@flourish86
Copy link
Contributor

flourish86 commented Feb 5, 2024

The message phrases are also not very user-friendly and could be improved visually and writing-wise.

Here are some suggestions, that could be discussed.

Frame 18

Frame 21

more to come …

@nilmerg
Copy link
Member Author

nilmerg commented Feb 5, 2024

Linking the recipient is currently questionable. We have no dedicated detail view, only a configuration form in case of contacts, and that is out of scope for this issue.

@ncosta-ic
Copy link
Member

Incorrect Source Icon

Internal events have no source, the icon is only shown because they are tied to objects still and such have a source. The source icon must reflect that they are internal events emitted by icinga-notifications. There's no icon or logo for this yet. @flourish86 may have input on this.

I currently render internal entries on the event list like the following:
external_vs_internal

@flourish86 Did you already come up with a design idea, on how we should differentiate events that are tied to a source (showing the source icon next to the "0m 00s ago") and ones that are not tied to a source (like in my example above where I placed a text placeholder)?

@ncosta-ic
Copy link
Member

ncosta-ic commented Mar 4, 2024

Incorrect Source Icon

Internal events have no source, the icon is only shown because they are tied to objects still and such have a source. The source icon must reflect that they are internal events emitted by icinga-notifications. There's no icon or logo for this yet. @flourish86 may have input on this.

@flourish86 Did you already come up with a design idea, on how we should differentiate events that are tied to a source (showing the source icon next to the "0m 00s ago") and ones that are not tied to a source (like in my example above where I placed a text placeholder)?

It was decided to drop the source information on internal events altogether, since they don't originate from an actual data source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/view Affects an entire view enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants