Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "find /..." without excludes #102

Open
hpreusse opened this issue Dec 21, 2020 · 0 comments
Open

Avoid "find /..." without excludes #102

hpreusse opened this issue Dec 21, 2020 · 0 comments

Comments

@hpreusse
Copy link

Anywhere in the code the diag script calls find like this

for i in $(find / -name php.ini 2>/dev/null)

Doing find /.... without any excludes is IMHO a bad idea, as we have a huge NFS share. Consider to use locate(1) in this situation and fall back to find(1) only if there is no locate(1) or it does not return results.

@hpreusse hpreusse changed the title Avoid "find /" Avoid "find /..." without excludes Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant