Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust UnreachableParent model #1115

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Adjust UnreachableParent model #1115

merged 1 commit into from
Dec 17, 2024

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Dec 17, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 17, 2024
@sukhwinder33445 sukhwinder33445 changed the base branch from main to dependencies December 17, 2024 14:11
@sukhwinder33445 sukhwinder33445 force-pushed the adjust-unreachable-parent-model branch from 51ffd5a to b54c6e6 Compare December 17, 2024 14:20
nilmerg
nilmerg requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's rather a child id, not a parent id 😉

@sukhwinder33445 sukhwinder33445 force-pushed the adjust-unreachable-parent-model branch from b54c6e6 to 3749421 Compare December 17, 2024 15:25
@sukhwinder33445
UnreachableParent: Fetch from_node_id column as child_id
1bab06f 
This column is required to make prepare the path chain of root-problem
@sukhwinder33445 sukhwinder33445 force-pushed the adjust-unreachable-parent-model branch from 3749421 to 1bab06f Compare December 17, 2024 15:26
@nilmerg nilmerg merged commit 299ca1f into dependencies Dec 17, 2024
22 checks passed
@nilmerg nilmerg deleted the adjust-unreachable-parent-model branch December 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhwinder33445 @nilmerg