Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form error handling flawed #28

Open
lippserd opened this issue Mar 30, 2020 · 1 comment
Open

Form error handling flawed #28

lippserd opened this issue Mar 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@lippserd
Copy link
Member

The current form error handling has the following flaws:

  • It swallows exception traces
  • isValid() is true even if the form has errors
  • Form error messages can't be styled, i.e. error markup is hardcoded in Form::onError()
@lippserd lippserd added the bug Something isn't working label Mar 30, 2020
@lippserd lippserd added this to the 0.4.0 milestone Apr 8, 2020
@nilmerg nilmerg removed this from the 0.4.0 milestone Jun 24, 2021
@nilmerg
Copy link
Member

nilmerg commented Oct 7, 2021

I'd add to it: break_chain_on_failure has no effect. (fix separately incoming)

nilmerg added a commit that referenced this issue Oct 7, 2021
@nilmerg
BaseFormElement: Don't evaluate validators by hand
2e720c2 
refs #28
@nilmerg nilmerg mentioned this issue Oct 7, 2021
Merged
nilmerg added a commit that referenced this issue Oct 7, 2021
@nilmerg
BaseFormElement: Don't evaluate validators by hand
6de8d6b 
refs #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lippserd @nilmerg