Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to continous delivery model #511

Open
jaragunde opened this issue Sep 13, 2021 · 1 comment
Open

Change to continous delivery model #511

jaragunde opened this issue Sep 13, 2021 · 1 comment

Comments

@jaragunde
Copy link
Member

Upstream PhpReport is provided with yearly releases, but that doesn't fit known actual deployments which are updated from the repository more often. It would be ideal to align upstream with this delivery process. We would also reduce the effort done in releases, which are completely manual at this point, and minimize errors.

We would have to guarantee that an admin is able to replace the files in their deployment with the files from the main branch in any given point (individual commits in branches merged into main would not count), and then be able to easily match their config and database. So I think we should:

  • version the database (already done, maybe change from "2.x" version names to incremental integers like db_version 3, 4, etc.)
    • for every change in the DB we commit in the future, we would bump the DB and probably include an upgrade script too
  • version the config file (e.g. define(CONFIG_VERSION, 2))
  • remove config.php from the repository to prevent overwriting local config (in fact, we already exclude this file from the release tarballs)
  • add initial checks in the program (during login?) to find out if it's running the correct DB and config version
@anarute
Copy link
Member

anarute commented Sep 15, 2021

@jaragunde cool, agree we should start prioritizing this.

A bit related, could you give me admin powers in the repository? I want to setup a github action to run the automated tests on pull requests and in the default branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants