Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit confirmation in holiday management screen #530

Open
jaragunde opened this issue Oct 23, 2021 · 0 comments
Open

Exit confirmation in holiday management screen #530

jaragunde opened this issue Oct 23, 2021 · 0 comments
Labels
backlog Bugs/features that need to be evaluated for future development component: frontend type: enhancement use case: holidays

Comments

@jaragunde
Copy link
Member

It would be good to ask for user confirmation when leaving the holiday management screen, in case there are unsaved changes. It's specially interesting because there is no visual feedback on there being unsaved changes or not.

The tasks screen has the same feature and it can be reused in this case, we'd need to include this file and implement a function called isUnsaved():

https://github.com/Igalia/phpreport/blob/main/web/js/include/closeConfirmation.js
@dmtrek14 dmtrek14 added backlog Bugs/features that need to be evaluated for future development and removed use case: tasks labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Bugs/features that need to be evaluated for future development component: frontend type: enhancement use case: holidays
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaragunde @dmtrek14