CI: Handle SSH host keys in upload script #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a known_hosts option when opening SFTP connections in the upload script, to validate that the host we are connecting to is indeed the one we expect. The data in OpenSSH's known_hosts format is picked from the UPLOAD_SSH_KNOWN_HOSTS environment variable.
|
I have added the |
aperezdc
force-pushed
the
aperezdc/ssh-known-hosts-upload
branch
3 times, most recently
from
98fcec5
to
1a2b4f1
Compare
Add a workflow input variable to determine whether built packages should be uploaded, which may come in useful for testing. By default, packages are only uploaded after successful merges.
aperezdc
force-pushed
the
aperezdc/ssh-known-hosts-upload
branch
from
1a2b4f1
to
65ef3a9
Compare
zhani
approved these changes
Nov 6, 2023
aperezdc
force-pushed
the
aperezdc/ssh-known-hosts-upload
branch
from
8fa4015
to
fd574b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
known_hostsoption when opening SFTP connections in the upload script, to validate that the host we are connecting to is indeed the one we expect. The data in OpenSSH'sknown_hostsformat is picked from theUPLOAD_SSH_KNOWN_HOSTSenvironment variable.