Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reps_And_Duration for type? #1157

Open
vfxdee opened this issue Dec 28, 2024 · 5 comments
Open

Add Reps_And_Duration for type? #1157

vfxdee opened this issue Dec 28, 2024 · 5 comments

Comments

@vfxdee
Copy link

vfxdee commented Dec 28, 2024

Could you add reps_and_duration and reps_and_duration_and_distance as types? If we're using this to track swimming laps we could use reps as a replacement for laps, then could track duration for the time per lap or total time for that set. We might also want to include distance swam in that as well. Is that a hard addition to make?

@IgnisDa
Copy link
Owner

IgnisDa commented Dec 29, 2024

Not very difficult, but I have a few questions.

image

What personal best types would be associated with these exercise types? Also what new best types can be calculated for them?

@vfxdee
Copy link
Author

vfxdee commented Dec 29, 2024

Hmm, I think reps/laps is definitely a thing. Time would be something. Could be time per lap or total time on laps. So best time would likely be shortest time per lap/rep (like total time divided by reps/laps = time per lap if not setting laps as sets or something). Volume/number of laps.

@IgnisDa
Copy link
Owner

IgnisDa commented Dec 29, 2024

Whats an exercise for reps_and_duration_and_distance?

@vfxdee
Copy link
Author

vfxdee commented Dec 29, 2024

Laps in a pool could be laps and duration or laps and duration and distance since you could also track distance swam. Running in a track could be the same. Admittedly, I'd use laps and duration more. I'm not much for a track or total distance travelled.

@IgnisDa
Copy link
Owner

IgnisDa commented Dec 29, 2024

Makes sense. But I won't have any of the inputs nullable. If you need that, you should create two different exercises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants