-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reps_And_Duration for type? #1157
Comments
Hmm, I think reps/laps is definitely a thing. Time would be something. Could be time per lap or total time on laps. So best time would likely be shortest time per lap/rep (like total time divided by reps/laps = time per lap if not setting laps as sets or something). Volume/number of laps. |
Whats an exercise for reps_and_duration_and_distance? |
Laps in a pool could be laps and duration or laps and duration and distance since you could also track distance swam. Running in a track could be the same. Admittedly, I'd use laps and duration more. I'm not much for a track or total distance travelled. |
Makes sense. But I won't have any of the inputs nullable. If you need that, you should create two different exercises. |
Could you add reps_and_duration and reps_and_duration_and_distance as types? If we're using this to track swimming laps we could use reps as a replacement for laps, then could track duration for the time per lap or total time for that set. We might also want to include distance swam in that as well. Is that a hard addition to make?
The text was updated successfully, but these errors were encountered: