Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default kphio values #414

Open
davidorme opened this issue Feb 5, 2025 · 0 comments
Open

Fix the default kphio values #414

davidorme opened this issue Feb 5, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@davidorme
Copy link
Collaborator

At present, the quantum yield calculations use Beni's default settings for his calibrated calculations with the soil moisture correction:

default_reference_kphio=0.049977,

default_reference_kphio=0.081785,

We need to set these to 1/8 and then update the soil moisture correction docs to explicitly say that you need to set those values to replicate the predictions of the Stocker calculations.

@davidorme davidorme added the bug Something isn't working label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant