Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly display changelog for F-Droid source with GitHub repository #2096

Closed
foolishgrunt opened this issue Jan 28, 2025 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@foolishgrunt
Copy link

Describe the feature
For projects such as AndrOBD, where the source code is hosted on GitHub but the maintainer does not provide Android binaries, the best solution is to pull from the corresponding F-droid repository. I would like to be able to view the changelog for this project (as provided on the GitHub releases page) from within Obtanium.

Describe alternatives you've considered (if applicable)
I'm aware that tapping the version number will open a web browser page to the project's GitHub releases page, where I can view the release notes. But seeing as Obtanium has the capability of displaying GitHub release notes from within the app, I think it would be ideal to extend this functionality to F-Droid sources that are linked to GitHub repositories.

Additional context
I believe the F-Droid build system detects that it's time to build a new version when a new "version tag" is detected on the GitHub releases page, which is then re-used as the version number on F-Droid. Therefore, the version numbers on F-Droid and on GitHub should always match (at least after the F-Droid build has caught up, at which point Obtainium would trigger an update.) Since Obtainium clearly is aware of the location of the GitHub releases page for this project (as evidenced when tapping on the version number), is there a way to also extract the release notes from that same page, perhaps by cross-referencing the appropriate version tag?

@foolishgrunt foolishgrunt added enhancement New feature or request to check Issue has not been reviewed labels Jan 28, 2025
@ImranR98
Copy link
Owner

ImranR98 commented Feb 2, 2025

  1. There would need to be some code that ensures the GitHub releases/tags are the same as what is available on F-Droid, which is not guaranteed to be the case since F-Droid releases are usually a few days (or longer) behind GitHub (and devs may release additional APKs on GitHub like betas or alt variants). This adds unnecessary complexity.
  2. Each time you check for updates on an F-Droid app, Obtainium would have to make a second request to GitHub. Not only does this take time and bandwidth (negligible), but it would also eat into the GitHub rate limit and cause problems for people with no GitHub access token.

In general I don't think it's a good idea long-term to try to mix data sources that can change independently/diverge.

@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2025
@ImranR98 ImranR98 removed the to check Issue has not been reviewed label Feb 2, 2025
@foolishgrunt
Copy link
Author

foolishgrunt commented Feb 3, 2025

Since it's the F-Droid repo that would be watched, I guess I don't see a problem if it lags a few days behind the GitHub repo - the corresponding version tag should always exist on GitHub, because that's what triggers the update in the F-Droid build system. I'll grant that some edge case could exist that I'm unfamiliar with where this would not be the case - although it seems like it would simple enough to fallback to existing behavior if no matching version tag is found.

But you raise a fair point about additional GitHub requests exceeding the rate limit. So be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants