Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file should have warning about the default settings #34

Open
trm42 opened this issue Jan 19, 2016 · 0 comments
Open

Config file should have warning about the default settings #34

trm42 opened this issue Jan 19, 2016 · 0 comments

Comments

@trm42
Copy link

trm42 commented Jan 19, 2016

Thanks for the awesome package.

I stumbled upon a problematic situation with Newrelic as I ended up using the default values for 'name_provider' (=> '{uri} {route}') in the config. It's nice way to use NR with Laravel, but in high-volume + lots of changing uris, we got contacted by Newrelic and they informed us that there's "unusually large number of unique transaction names".

So how about adding additional warning or suggestion to the config file which says something like "If you have lots of different uris, drop the {uri} from the config as Newrelic doesn't recommend over 1000 transaction names"? Probably saves some work from people using your package and from Newrelic as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant