Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes use 'Piwik' name, change to something more specific #11

Open
kevinb456 opened this issue Nov 12, 2013 · 1 comment
Open

classes use 'Piwik' name, change to something more specific #11

kevinb456 opened this issue Nov 12, 2013 · 1 comment
Assignees

Comments

@kevinb456
Copy link
Contributor

The classes used for the mod use the name Piwik;

class ControllerModulePiwik extends Controller
class ModelToolPiwik extends Model

etc.

so when the mod is installed or settings are changed, all the operations are done with the 'extension' GET variable of 'piwik'. This could get in the way of an "official" Piwik module if they ever have one?

Change to be something more specific to this mod.

@kevinb456
Copy link
Contributor Author

Also remember to think about backwards compatibility with previous users, as all the database settings will be stored based on the 'piwik' module name.

@kevinb456 kevinb456 self-assigned this Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant