Kdesktop 1359 vfs functions should return an exit info

extensions/windows/cfapi/Vfs/Vfs.vcxproj

@@ -162,7 +162,7 @@
       <Command>copy /Y "$(ProjectDir)..\Common\debug.h" "F:\Projects\desktop-kDrive\src\server\vfs\win\."
 copy /Y "$(ProjectDir)$(TargetName).h" "F:\Projects\desktop-kDrive\src\server\vfs\win\."
 copy /Y "$(TargetDir)$(TargetName).dll" "F:\Projects\build-desktop-kDrive-Desktop_Qt_6_2_3_MSVC2019_64bit-Debug\bin\."
-copy /Y "$(TargetDir)$(TargetName).pdb" "F:\Projects\build-desktop-kDrive-Desktop_Qt_6_2_3_MSVC2019_64bit-Debug\bin\."
+copy /Y "$(TargetDir)$(TargetName).pdb" "F:\Projects\build-desktop-kDrive-Desktop_Qt_6_2_3_MSVC2019_64bit-Debug\."
 </Command>
     </PostBuildEvent>
   </ItemDefinitionGroup>

infomaniak-build-tools/windows/build-drive.ps1

@@ -378,7 +378,7 @@ $dependencies = @(
 "${env:ProgramFiles(x86)}/Sentry-Native/bin/sentry",
 "${env:ProgramFiles(x86)}/xxHash/bin/xxhash",
 "$vfsDir/Vfs",
-"$buildPath/bin/kDrivesyncengine_vfs_win"
+"$buildPath/bin/kDrivecommonserver_vfs_win"
 )
 
 Write-Host "Copying dependencies to the folder $archivePath"

infomaniak-build-tools/windows/upload-ci.ps1

@@ -29,7 +29,7 @@ $files = @(
     $app,
     "kDrive.pdb",
     "kDrive_client.pdb",
-    "kDrivesyncengine_vfs_win.pdb"
+    "kDrivecommonserver_vfs_win.pdb"
 )
 
 $headers = @{

src/libcommon/utility/sourcelocation.h

@@ -0,0 +1,86 @@
+/*
+ * Infomaniak kDrive - Desktop
+ * Copyright (C) 2023-2024 Infomaniak Network SA
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#pragma once
+
+#if defined(_WIN32)
+// || defined(__APPLE__) still buggy on macOS
+// https://www.reddit.com/r/cpp/comments/1b1pjii/comment/ksg8efc/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
+
+#define SRC_LOC_AVALAIBALE
+#endif
+
+#ifdef SRC_LOC_AVALAIBALE
+#include <source_location>
+#endif // SRC_LOC_AVALAIBALE
+
+#include <filesystem>
+#include <string>
+
+namespace KDC {
+
+class SourceLocation {
+    public:
+        constexpr SourceLocation() = default;
+#ifdef SRC_LOC_AVALAIBALE
+        [[nodiscard]] static consteval SourceLocation currentLoc(
+                const std::source_location& loc = std::source_location::current()) {
+            SourceLocation result;
+            result._line = loc.line();
+            result._fileName = loc.file_name();
+            result._functionName = loc.function_name();
+            return result;
+        }
+#else
+        // This is a workaround for the lack of support for std::source_location.
+        // It is not as accurate as std::source_location but it is better than nothing.
+        // void foo(SourceLocation loc = currentLoc()) -> loc will be evaluated at the definition site instead of the call site.
+#define currentLoc() currentLocCompatibility(__LINE__, __FILE__)
+        [[nodiscard]] static consteval SourceLocation currentLocCompatibility(uint32_t line, const char* file) {
+            SourceLocation result;
+            result._line = line;
+            result._fileName = file;
+            return result;
+        }
+#endif // SRC_LOC_AVALAIBALE
+
+        [[nodiscard]] uint32_t line() const { return _line; }
+        [[nodiscard]] std::string fileName() const { return std::filesystem::path(_fileName).filename().string(); }
+        [[nodiscard]] std::string functionName() const {
+            std::string str(_functionName);
+            auto firstParenthesis = str.find_first_of('(');
+            str = firstParenthesis != std::string::npos
+                          ? str.substr(0, firstParenthesis)
+                          : str; // "namespace::class::function(namespace::args)" -> "namespace::class::function"
+            auto lastColon = str.find_last_of(':');
+            return lastColon != std::string::npos ? str.substr(lastColon + 1) : str; // "namespace::class::function" -> "function"
+        }
+        [[nodiscard]] std::string toString() const {
+            return fileName() + ":" + std::to_string(line()) +
+                   (functionName().empty() ? "" : "[" + functionName() + "]");
+        }
+
+
+    private:
+        uint32_t _line = 0;
+        const char* _fileName = "";
+        const char* _functionName = "";
+};
+
+} // namespace KDC
+// namespace KDC

src/libcommon/utility/types.h

@@ -15,7 +15,6 @@
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-
 #pragma once
 
 #include <string>
@@ -28,6 +27,7 @@
 #include <variant>
 #include <qdebug.h>
 #include <signal.h>
+#include "sourcelocation.h"
 
 namespace KDC {
 
@@ -230,32 +230,50 @@ enum class ExitCause {
     MoveToTrashFailed,
     InvalidName,
     LiteSyncNotAllowed,
+    NotPlaceHolder,
     NetworkTimeout,
     SocketsDefuncted, // macOS: sockets defuncted by kernel
     NotFound,
     QuotaExceeded,
     FullListParsingError,
     OperationCanceled,
-    ShareLinkAlreadyExists
+    ShareLinkAlreadyExists,
+    InvalidArgument
 };
 std::string toString(ExitCause e);
 
 struct ExitInfo {
         ExitInfo() = default;
-        constexpr ExitInfo(const ExitCode &code, const ExitCause &cause) : _code(code), _cause(cause) {}
-        ExitInfo(const ExitCode &code) : _code(code) {}
+        constexpr ExitInfo(const ExitCode &code, const ExitCause &cause,
+                           const SourceLocation srcLoc = SourceLocation::currentLoc()) :
+            _code(code),
+            _cause(cause), _srcLoc(srcLoc) {}
+
+        ExitInfo(const ExitCode &code, const SourceLocation srcLoc = SourceLocation::currentLoc()) :
+            _code(code), _srcLoc(srcLoc) {}
+
         const ExitCode &code() const { return _code; }
         const ExitCause &cause() const { return _cause; }
         operator ExitCode() const { return _code; }
         operator ExitCause() const { return _cause; }
-        explicit operator std::string() const { return "ExitInfo{" + toString(code()) + ", " + toString(cause()) + "}"; }
+        explicit operator std::string() const {
+            // Example: "ExitInfo{SystemError-NotFound from (file.cpp:42[functionName])}"
+            // Example: "ExitInfo{Ok-Unknown}"
+            return "ExitInfo{" + toString(code()) + "-" + toString(cause()) + srcLocStr() + "}";
+        }
         constexpr operator bool() const { return _code == ExitCode::Ok; }
         constexpr explicit operator int() const { return toInt(_code) * 100 + toInt(_cause); }
         constexpr bool operator==(const ExitInfo &other) const { return _code == other._code && _cause == other._cause; }
 
     private:
         ExitCode _code{ExitCode::Unknown};
         ExitCause _cause{ExitCause::Unknown};
+        SourceLocation _srcLoc;
+
+        std::string srcLocStr() const {
+            if (_code == ExitCode::Ok) return "";
+            return " from (" + _srcLoc.toString() + ")";
+        }
 };
 std::string toString(ExitInfo e);
 

src/libcommonserver/CMakeLists.txt

@@ -1,5 +1,6 @@
 project(libcommonserver)
 
+find_package(Qt6 REQUIRED Core)
 find_package(SQLite3 3.8.0 REQUIRED)
 find_package(Poco 1.13.3 REQUIRED Foundation Net JSON Util)
 find_package(OpenSSL 3.1.0 REQUIRED SSL Crypto)
@@ -11,9 +12,13 @@ if (UNIX AND CMAKE_BUILD_TYPE MATCHES "RelWithDebInfo")
 endif ()
 find_package(libzip 1.10.1 REQUIRED)
 
+set(CMAKE_AUTOMOC TRUE)
+
 add_definitions(-DUNICODE)
 add_definitions(-D_UNICODE)
 
+add_subdirectory(vfs)
+
 # Sources
 set(libcommonserver_SRCS
     # Utility
@@ -34,6 +39,9 @@ set(libcommonserver_SRCS
     # Io
     io/filestat.h
     io/iohelper.h io/iohelper.cpp
+    vfs/vfs.h vfs/vfs.cpp
+    vfs/workerinfo.h vfs/vfsworker.h
+    vfs/plugin.h vfs/plugin.cpp
 )
 
 if(APPLE)