Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add [dedupe] #385

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: 🎸 add [dedupe] #385

merged 2 commits into from
Nov 27, 2023

Conversation

touv
Copy link
Contributor

@touv touv commented Nov 27, 2023

No description provided.

@touv touv merged commit 9e1d0ca into master Nov 27, 2023
11 of 12 checks passed
@touv touv deleted the dedupe branch November 27, 2023 12:25
* @param {Boolean} [ignore = false] Just ignore duplicate object
* @returns {Object}
*/
export default async function identify(data, feed) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that function be named dedupe, and not identify ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, it will be better for the doc ...
image
and I will correct another similar error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants