Fix validate config (#481)

* Fixed path issue in validate-config

* Made paths relative to config

* Make union optional

* Updated parse_rule to use root of config

src/fixit/config.py

@@ -602,12 +602,13 @@ def validate_config(path: Path) -> List[str]:
     """
     exceptions: List[str] = []
     try:
+        root = path.parent
         configs = read_configs([path])[0]
 
-        def validate_rules(rules: List[str], path: Path, context: str) -> None:
+        def validate_rules(rules: List[str], context: str) -> None:
             for rule in rules:
                 try:
-                    qualified_rule = parse_rule(rule, path, configs)
+                    qualified_rule = parse_rule(rule, root, configs)
                     try:
                         for _ in find_rules(qualified_rule):
                             pass
@@ -621,19 +622,17 @@ def validate_rules(rules: List[str], path: Path, context: str) -> None:
                     )
 
         data = configs.data
-        validate_rules(data.get("enable", []), path, "global enable")
-        validate_rules(data.get("disable", []), path, "global disable")
+        validate_rules(data.get("enable", []), "global enable")
+        validate_rules(data.get("disable", []), "global disable")
 
         for override in data.get("overrides", []):
             override_path = Path(override.get("path", path))
             validate_rules(
                 override.get("enable", []),
-                override_path,
                 f"override enable: `{override_path}`",
             )
             validate_rules(
                 override.get("disable", []),
-                override_path,
                 f"override disable: `{override_path}`",
             )
 

src/fixit/tests/config.py

@@ -680,6 +680,35 @@ def test_validate_config(self) -> None:
 
                 self.assertEqual(results, [])
 
+    def test_validate_config_with_override(self) -> None:
+        with self.subTest("validate-config valid with overrides"):
+            with TemporaryDirectory() as td:
+                tdp = Path(td).resolve()
+                path = tdp / ".fixit.toml"
+                (tdp / "rule/ruledir").mkdir(parents=True, exist_ok=True)
+
+                (tdp / "rule/rule.py").write_text("# Rule")
+                (tdp / "rule/ruledir/rule.py").write_text("# Rule")
+                path.write_text(
+                    """
+                    [tool.fixit]
+                    disable = ["fixit.rules"]
+                    root = true
+
+                    [[tool.fixit.overrides]]
+                    path = "SUPER_REAL_PATH"
+                    enable = [".rule.rule"]
+
+                    [[tool.fixit.overrides]]
+                    path = "SUPER_REAL_PATH/BUT_ACTUALLY_REAL"
+                    enable = [".rule.ruledir.rule"]
+                    """
+                )
+
+                results = config.validate_config(path)
+
+                self.assertEqual(results, [])
+
         with self.subTest("validate-config invalid config"):
             with TemporaryDirectory() as td:
                 tdp = Path(td).resolve()