-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Infomodel and Serializer #634
Comments
Would imply the following constellation for Messaging-Services (see linked PR):
From experience, there will also be breaking changes for the DSC and not just for the Messaging-Services itself, which will have to be tested and adressed in the run-up to the PR. So even if the PR in the Messaging-Services itself can be merged successfully, there could still be breaking conflicts in the DSC, which need to be evaluated beforehand before merging the linked PR. |
There are two main breaking changes compared to the DSC:
|
@rmsoyta could you provide some more feedback on requirements from your side? Maybe we could find a version which does not lead to incompabilities but would satisfy your requirements. |
A short comment on that. Up to my current understanding, the breaking changes will be caused by the evolution of the version of the java classes (@tmberthold , @SebastianOpriel )? I think so because the serializer should be independent of the info model version used. It is included as test-dependency only and is (sadly) the sole target we test the serializer against. The changes in the interaction library (compared to the latest previous version) are marginal in the sense that we only updated the dependencies. You could give it a trial and solely include the update of the serializer. This shouldn't cause breaking changes. |
We have updated the serializer in the DSC as a test, but the e2e-tests of the DSC fail, so changes are hiding here as well. |
There was a release for Infomodel Serializer with some performance improvements (v5.0.3). These changes could be integrated into messaging services, if no problems arise.
The Infomodel itself got also updated. It may be discussed, if the Infomodel is backwards compatible and could be integrated smoothly into messaging services and then into DSC (but needs good compatibility checks). The reason is that IAIS is working on integrating messaging services into Broker Core for MDS see https://github.com/Mobility-Data-Space/MDS-Broker-Core/tree/feature/ids_messaging_services They would like to use the latest updates of serializer and infomodel dependencies in messaging-services
The text was updated successfully, but these errors were encountered: