Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor|Bug] Properties Panel Can Expand Without Bounds #200

Merged
merged 1 commit into from
Mar 1, 2021
Merged

[Editor|Bug] Properties Panel Can Expand Without Bounds #200

merged 1 commit into from
Mar 1, 2021

Conversation

PythooonUser
Copy link
Contributor

@PythooonUser PythooonUser commented Jan 9, 2021 •
edited
Loading

Summary

Fixes #199.

Fixes the entity properties panel resizing behavior.

  • Maximum width of panel restricted to 25% of screen width
  • Width adjusts dynamically when altering values in panel (growing/shrinking)
  • Same width when closing/opening panel
  • Width changes properly when resizing editor window

@PythooonUser
Copy link
Contributor Author

@Interrupt Hey Chad, when testing I noticed that the left padding is changed when the size of the pane changes. Any ideas? Maybe calling pack on the properties menu breaks things?

grafik

@joshuaskelly joshuaskelly merged commit a47df44 into Interrupt:master Mar 1, 2021
@PythooonUser PythooonUser deleted the bugfix/199-Properties-Panel-Size branch March 1, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Interrupt Interrupt Interrupt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Editor|Bug] Properties Panel Can Expand Without Bounds
3 participants
@PythooonUser @Interrupt @joshuaskelly