Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or Remove Custom Java Scripting #267

Open
joshuaskelly opened this issue Oct 21, 2021 · 2 comments
Open

Fix or Remove Custom Java Scripting #267

joshuaskelly opened this issue Oct 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@joshuaskelly
Copy link
Collaborator

Summary

Java scripting is currently broken because it requires the JavaCompiler class which is a JDK feature in Java 8 and not available in the JRE.

Notes

Ship tools.jar

I've tried adding the tools.jar from the JDK libs directory to the JRE libs directory and adding the additional vmarg -Xbootclasspath/a:jre/lib/tools.jar to ensure it can find the library. This works okay from the command line, but does not work from the binaries we ship.

Update Bundled JRE

I've also tried Java 17 now that it has entered an LTS state. It appears that the JavaCompiler is now included with the JRE but how we patch the class path was broken.

@joshuaskelly joshuaskelly added the bug Something isn't working label Oct 21, 2021
@PythooonUser
Copy link
Contributor

Can be closed?

@joshuaskelly
Copy link
Collaborator Author

No. This has not be addressed either way yet. I've temporarily disabled custom scripting because it currently does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants