Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting Entity Fields Does Not Add to Editor History #273

Open
joshuaskelly opened this issue Nov 3, 2021 · 2 comments
Open

Adjusting Entity Fields Does Not Add to Editor History #273

joshuaskelly opened this issue Nov 3, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@joshuaskelly
Copy link
Collaborator

Summary

Editing entity properties does not get recorded and does not allow undo/redo. This will likely require changes to PropertiesMenu.java to save history when fields are changed.

@joshuaskelly joshuaskelly added bug Something isn't working good first issue Good for newcomers labels Nov 3, 2021
@PythooonUser
Copy link
Contributor

Started working on this! 🎉

@PythooonUser
Copy link
Contributor

One problem I faced is that the properties menu hides when performing an undo action. In case you made a change to an entity field and the entity still exists after the undo action, I want the properties menu to stay open and simply refresh.

The issue here is that we are deserializing the level anew, therefore, the entity before and after the undo action is not the same anymore.

We need some way to establish equality of entities. Is there a way to introduce a unique hash? Obviously, after the undo action at least one field value is different between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants