Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Use BackpackSize Instead of InventorySize #286

Open
PythooonUser opened this issue Jun 19, 2022 · 0 comments · May be fixed by #287
Open

[REFACTOR] Use BackpackSize Instead of InventorySize #286

PythooonUser opened this issue Jun 19, 2022 · 0 comments · May be fixed by #287

Comments

@PythooonUser
Copy link
Contributor

PythooonUser commented Jun 19, 2022 •
edited
Loading

Right now we have a hotbarSize and an inventorySize. inventorySize, however, is the combination of hotbar and backpack. It would be easier when we use a hotbarSize and backpackSize, and calculate the current inventorySize on the fly.

This way, we could easier track just how much upgrades for hotbar or backpack where used to trigger the achievement. Without the need of calculations of the actual sizes.

This would be a good refactor for the preparation of #215.
@PythooonUser PythooonUser changed the title Use BackpackSize Instead of InventorySize [REFACTOR] Use BackpackSize Instead of InventorySize Jun 19, 2022
@PythooonUser PythooonUser linked a pull request Jun 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backpackSize Refactor PythooonUser/delverengine
1 participant
@PythooonUser