1678: epoch_stake missing entries #1796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
1678-epoch_stake-missing-entries
branch
2 times, most recently
from
4775489
to
9644c31
Compare
Cmdv
force-pushed
the
1678-epoch_stake-missing-entries
branch
from
9644c31
to
13838d6
Compare
Cmdv
force-pushed
the
1678-epoch_stake-missing-entries
branch
from
6f545af
to
0242576
Compare
kderme
reviewed
Aug 14, 2024
| assertEpochStake dbSync 5 | ||
| blks <- fillUntilNextEpoch interpreter mockServer | ||
| assertBlockNoBackoff dbSync (fromIntegral $ length blks) | ||
| -- There are 10 delegations in genesis |
There was a problem hiding this comment.
Is this comment correct or is the old comment wrong about genesi?
There was a problem hiding this comment.
it can be removed. I think in the previous implementation, by the time the assertEpochStake was called the epoch 2 wouldn't have been inserted. This is why I changed the tests to check each epoch 1 + 2 separately
What modification does it need? I'm happy to make the changes or discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1678
Currently trying to log out the slice function as it's not behaving correctly
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.