Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Missing Test ID for Sort Button After UI Update #2838

Open
kneerose opened this issue Jan 30, 2025 · 1 comment
Open

🐛 Missing Test ID for Sort Button After UI Update #2838

kneerose opened this issue Jan 30, 2025 · 1 comment
Assignees
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar

Comments

@kneerose
Copy link
Contributor

Area

Proposal Pillar

Domain

preview.gov.tools

Which wallet were you using?

No response

Context

While running the test for sorting on the proposal list, the test failed due to a missing test ID on the sort button, resulting in a timeout. Previously, the test ID for the sort button was sort-button. However, after a recent UI update, it seems to have been removed unintentionally.

Test Report:

Steps to reproduce

  1. Navigate to the proposal page.
  2. Inspect the sort button for the test ID.

Actual behavior

  • The test ID for the sort button is missing.

Expected behavior

  • Even after a UI update, the sort button should retain a proper test ID, as previously assigned, to ensure test stability

Note

  • Please check the previous test ID and add it to the updated UI.
@kneerose
Copy link
Contributor Author

@nebojsact, if you are adding a test ID to the sort button, please update the test ID for the show-all button as well. Currently, both the treasury and info proposal show-all buttons use the same test ID, show-all-button. Instead, use info-show-all-button and treasury-show-all-button to differentiate them.

Image

Image

@bosko-m bosko-m moved this to To do in Govtool all Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar
Projects
Status: No status
Status: To do
Development

No branches or pull requests

2 participants