Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused OS based differentiation from the CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method #198

Closed
fabiobrz opened this issue Sep 4, 2024 · 6 comments
Closed

Remove unused OS based differentiation from the CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method #198

fabiobrz opened this issue Sep 4, 2024 · 6 comments
Assignees
@TheMarvelFan
Labels
good first issue Good for newcomers hacktoberfest
Milestone
Intersmash 0.0.3 ...

Comments

@fabiobrz
Copy link
Member

fabiobrz commented Sep 4, 2024 •
edited
Loading

The CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method is taking the mac value for the os.name system property into account, which doesn't make sense, since Intersmash only supports Linux execution.

The method should be removed altogether.

See #180 (comment)

  • Environment: core module
  • Steps to reproduce: N/A
@fabiobrz fabiobrz mentioned this issue Sep 4, 2024
Merged
10 tasks
@fabiobrz fabiobrz changed the title Remove unused OS based differentiation fromm the Remove unused OS based differentiation from the CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method Sep 4, 2024
@fabiobrz fabiobrz moved this to Todo in Intersmash library Sep 5, 2024
@fabiobrz fabiobrz added the good first issue Good for newcomers label Sep 20, 2024
@TheMarvelFan
Copy link
Contributor

Hi,
Is anyone working on this issue?

@fabiobrz
Copy link
Member Author

Hi,

Is anyone working on this issue?

Hi @TheMarvelFan, and thanks for your question.
Nobody is working on this issue, would you like to take it?
We love for the community to contribute, so you'd have a green light here! 🙂

@TheMarvelFan
Copy link
Contributor

Yes I'd love to work on it.

@fabiobrz
Copy link
Member Author

Yes I'd love to work on it.

Thanks! I've ssigned the issue to you, then 🙂

@fabiobrz fabiobrz moved this from Todo to In Progress in Intersmash library Sep 24, 2024
@TheMarvelFan TheMarvelFan mentioned this issue Sep 25, 2024
Merged
10 tasks
@TheMarvelFan
Copy link
Contributor

Hi @fabiobrz,

I've made the necessary changes and opened a PR. Please review it and let me know if any changes are rerquired.

Thanks!

@fabiobrz fabiobrz moved this from In Progress to Done in Intersmash library Sep 26, 2024
@fabiobrz
Copy link
Member Author

Closing as done via #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheMarvelFan TheMarvelFan

Labels
good first issue Good for newcomers hacktoberfest
Projects
Intersmash library
Status: Done
Milestone
Intersmash 0.0.3 - Open Data Hub/Open...
Development

No branches or pull requests
2 participants
@fabiobrz @TheMarvelFan