Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support latest WildFly(35.0.0.Final)/EAP(8.1 & XP 6) #225

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Support latest WildFly(35.0.0.Final)/EAP(8.1 & XP 6) #225

merged 13 commits into from
Jan 23, 2025

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Jan 14, 2025 •
edited
Loading

Description

SSIA

Resolves #222

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Jan 14, 2025
@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch 2 times, most recently from c81f51b to 4b28264 Compare January 15, 2025 14:12
@fabiobrz fabiobrz changed the title Bump.wildfly eap.003 Support latest WildFly/EAP Jan 15, 2025
@fabiobrz fabiobrz changed the title Support latest WildFly/EAP Support latest WildFly(35.0.0.Final)/EAP(XP 6) Jan 15, 2025
@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch 2 times, most recently from b89c504 to 724d46a Compare January 16, 2025 12:35
@fabiobrz fabiobrz changed the title Support latest WildFly(35.0.0.Final)/EAP(XP 6) Support latest WildFly(35.0.0.Final)/EAP(8.1 & XP 6) Jan 16, 2025
@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#178> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#1> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#1> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#102> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#1> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-81#1> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#181> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#3> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#3> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#104> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#3> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-81#3> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

/test

1 similar comment
@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#184> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#5> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#5> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#106> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#5> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch from 42b9451 to ce949ee Compare January 17, 2025 13:49
@fabiobrz
Copy link
Member Author

/test

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch from ce949ee to dcb3317 Compare January 17, 2025 13:59
@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#186> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#6> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#6> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#107> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#6> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-81#6> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#187> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#7> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#7> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#108> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#7> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-81#7> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch 3 times, most recently from af77b67 to 4dfbf89 Compare January 17, 2025 15:42
@fabiobrz
Copy link
Member Author

/test

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch from bc04b50 to 2696567 Compare January 20, 2025 10:22
@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#195> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#11> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#11> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#112> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#11> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-81#11> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch from 2696567 to eda9322 Compare January 22, 2025 07:25
@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#197> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#12> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#12> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#113> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#12> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-81#12> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

/test

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch from 1a78651 to c7765e1 Compare January 22, 2025 10:07
@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#200> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp6#14> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#14> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

/test

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#202> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#15> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#116> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#15> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz
Copy link
Member Author

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see #225 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#202> FAILED:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#15_> reported failures.

2 failures:

  • org.jboss.intersmash.testsuite.provision.openshift.Eap7ImageProvisionerTestCase.deploy - which is intermittent and passing in the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#16> ✅
  • org.jboss.intersmash.testsuite.provision.openshift.WildflyBootableJarTestCase.deploy - which is intermittent and passing in the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp5#16>
* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-community#116_> reported failures.

1 failure:

  • org.jboss.intersmash.testsuite.provision.openshift.ActiveMQOpenShiftOperatorProvisionerTest.createOperatorGroup

Which is intermittent and passing in the subsequent run: <eap-8.x-intersmash-integration-tests-community#117> ✅

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-80#15_> reported failures.

1 failure:

  • org.jboss.intersmash.testsuite.provision.openshift.ProvisionerCleanupTestCase.eap7LegacyS2iBuild

Which is intermittent and passing in the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap-80#16> ✅

  Please verify your changes locally or reach out to maintainers in order to investigate the issues.

Based on the above findings, the changes in the PR are deemed to pass the integration tests and can now be reviewed.

@fabiobrz fabiobrz requested a review from marekkopecky January 22, 2025 16:17
@fabiobrz
Copy link
Member Author

Hi @marekkopecky - all the checks are green here and this is ready for a review, as the last step before releasing a version to be used when testing EAP 8.1 and XP 6, too.
Feel free to reach out for any concerns and let me know whether you'd want for me to squash the commits.

@marekkopecky
Copy link
Collaborator

Hi @fabiobrz , thank you for this PR. I have just one minor comment, otherwise LGTM. I think that keeping the commits without squashing can be useful for the future.

@fabiobrz
Copy link
Member Author

Hi @fabiobrz , thank you for this PR. I have just one minor comment, otherwise LGTM. I think that keeping the commits without squashing can be useful for the future.

Thanks @marekkopecky. Actually those methods are overridden as well, they're missing just the annotation.
The adapters follow the related design pattern quite strictly, so I am not sure that Javadoc is needed.
Would you agree if I just add the @Override annotation where it's missing?

AAnd BTW thanks for your feedback about the commits, I do agree.

@marekkopecky
Copy link
Collaborator

Would you agree if I just add the @OverRide annotation where it's missing?

yes, I agree. It's not necessary to always add javadoc to overridden methods ...

fabiobrz added 13 commits January 23, 2025 15:20
@fabiobrz
[issue-222] - Add EAP XP 6 and EAP 8.1 Helm Charts values schema file…
43799e7 
…s and adapters
@fabiobrz
[issue 222] - Update documentation and global-test.properties file
0b5e62b
@fabiobrz
[issue-222] - Bumping WildFly and related artifacts to latest
11e9994
@fabiobrz
[issue-222] (Unrelated) - Yet another update of documentation about l…
1ce92f5 
…atest supported versions, based on the defaults provided by OpenShift as of today
@fabiobrz
[issue-222] - Add profiles for building EAP XP 5 and EAP XP 6 deploym…
e9b9447 
…ents
@fabiobrz
[issue-222] - Add EAP XP 6 and EAP 8.1 cases to Helm Charts integrati…
276cf24 
…on tests
@fabiobrz
[issue-222] - Update documentation about testsuite profiles
5dac76a
@fabiobrz
[issue-222] - Update the Botable JAR MAven plugin version to 12.0.0.F…
d8bb256 
…inal
@fabiobrz
[issue-222] - Create separate configuration files and profiles to ena…
ccc69d8 
…ble profiles that test against a given WildFly/EAP(8.0,8.1)/EAP XP(5,6) version and to build deployments with the expected bits
@fabiobrz
[issue-222] (Unrelated) - Fix formatting
a72dee7
@fabiobrz
[issue-222] - Fix passing profiles to OCP builds
c34ced8
@fabiobrz
[issue-222] - Fix profiles that set deployments-provider properties
059162e
@fabiobrz
[issue-222] - Fix the WildFlyHelmChartProvisionerTest, as the related…
bc36841 
… application must explicitly use .build.mode=s2i
@fabiobrz fabiobrz force-pushed the bump.wildfly-eap.003 branch from a62669d to bc36841 Compare January 23, 2025 14:21
@marekkopecky
Copy link
Collaborator

Thank you, merging!

@marekkopecky marekkopecky merged commit 2a6be00 into Intersmash:main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekkopecky marekkopecky marekkopecky left review comments

Assignees

@marekkopecky marekkopecky

Labels
dependencies Pull requests that update a dependency file it-passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support latest WildFly/EAP
2 participants
@fabiobrz @marekkopecky