Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB support #12

Open
Bet1K opened this issue Oct 28, 2019 · 2 comments
Open

Add DB support #12

Bet1K opened this issue Oct 28, 2019 · 2 comments

Comments

@Bet1K
Copy link

Bet1K commented Oct 28, 2019

Please add some sort of DB support. My books have disappeared again (haven't used reload command)

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.95. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@Th3Shadowbroker
Copy link
Contributor

Th3Shadowbroker commented Oct 28, 2019

Hi @Bet1K,
thanks for the feature-request 🙂
In this particular case, this issue is a feature request, as well as a bug report.

Regarding the bug-report:
As far as I know, Bookshelves uses the block's meta-data to store the shelf-inventory. When the server starts, this information is loaded through a scheduled task, which injects the inventory-data into the blocks (were it's kept only during runtime). When reloaded, the meta-data is kept and the plugin restores it's knowledge using the already loaded meta-data from the blocks. The data only gets saved (written to the file), when the plugin is disabled correctly (No crashes and no forced restarts). (Correct me if I'm wrong @InventivetalentDev). Could you please create a separate issue with more details on that using this issue-template for bug-reports so we can try to replicate it and have a closer look at the problem? 🙂

Regarding the feature request:
Actually a database sound like a great idea, however, as I explained before, the data gets loaded once and is then injected into the assigned blocks meta-data. So it don't really get the advantage of using a database instead of a flatfile. The only exception, beeing a scenario, where you have the same world on multiple servers and want to synchronize it. Do you have this scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants