Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookshelves Support Hoppers #14

Open
FlowerOLife opened this issue Nov 18, 2019 · 5 comments
Open

Bookshelves Support Hoppers #14

FlowerOLife opened this issue Nov 18, 2019 · 5 comments

Comments

@FlowerOLife
Copy link

Wondering if hopper support could be added to bookshelves? :D

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.80. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@Th3Shadowbroker
Copy link
Contributor

I'll have a look into that 🙂

@Th3Shadowbroker
Copy link
Contributor

Th3Shadowbroker commented Nov 27, 2019

Brief status update:

  • Identified event triggered by hoppers
  • Added config setting (See Th3Shadowbroker@484e28e)
  • Bookshelves accept incoming items from hoppers (See Th3Shadowbroker@ea5f915)
  • Bookshelves support output through hoppers (See Th3Shadowbroker@2c844ec)
  • Bookshelves do not continue processing their content after a server-restart or when a full inventory is no longer full.

One thing I noticed is, that the InventoryMoveItemEvent requires a transfer through at least 2 or more hoppers to be fired but this shouldn't be a real problem.

@Th3Shadowbroker
Copy link
Contributor

Th3Shadowbroker commented Dec 8, 2019

cc: @InventivetalentDev

@FlowerOLife Sooo....I finally had some time to continue working on this after a busy week and I've built a prototype with a different approach. Please have a look and tell me what you think.
Bookshelves_v1.6.0-SNAPSHOT.jar.zip (Had to ZIP it, as jar files are only directly support for releases). I've also added some extra delay to the shelves when checking for in-/outputs, to improve the performance. To enable hopper support, please have a look at the config-file:

# Hopper support
hoppers: true

I'll attach a PR below and update it in case any changes are suggested 🙂

@Th3Shadowbroker
Copy link
Contributor

I guess everything is done here ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants