Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight OpenSCAD echo #470

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Highlight OpenSCAD echo #470

merged 1 commit into from
Aug 22, 2021

Conversation

Irev-Dev
Copy link
Owner

@Irev-Dev Irev-Dev commented Aug 22, 2021

As suggested by @OutwardBuckle in #464

What are your thoughts on this @franknoirot? I figure why not, would be easy to reverse later if it somehow is a problem.
Not sure about the colors 🤷

image

Resolves #469

@Irev-Dev Irev-Dev requested a review from franknoirot August 22, 2021 00:49
@Irev-Dev Irev-Dev mentioned this pull request Aug 22, 2021
@franknoirot
Copy link
Collaborator

This is a great idea! I support it, and I think your color choices work well.

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@Irev-Dev Irev-Dev merged commit 96fa776 into main Aug 22, 2021
@Irev-Dev Irev-Dev deleted the kurt/469 branch August 22, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight OpenSCAD echo
2 participants