Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting island can remove itens from visiting players #847

Open
Micosedeunha opened this issue May 13, 2024 · 0 comments · May be fixed by #848
Open

Deleting island can remove itens from visiting players #847

Micosedeunha opened this issue May 13, 2024 · 0 comments · May be fixed by #848
Assignees
@PeachesMLG @dlsf @MertUnverdi
Labels
bug Something isn't working high unconfirmed An issue that needs further investigation

Comments

@Micosedeunha
Copy link

When a player delete its island and other is visiting it, both get their itens removed.

Steps to reproduce the behavior:

  1. have an island
  2. get someone to visit your island (not a member of the island)
  3. delete the island with remove itens when delete set to true
  4. All player that were in the island delete should get their itens removed

Expected to remove itens only from member of the island

Server and Plugin Version
server version 1.20.4
plugin version 4.1.0 BETA

Additional context
Also, if the leader delete his island out of it (any other place) the itens wont be deleted.
@Micosedeunha Micosedeunha added bug Something isn't working unconfirmed An issue that needs further investigation labels May 13, 2024
sh0inx added a commit that referenced this issue May 13, 2024
@sh0inx
Rewrote clearTeamInventory to fix #847
97fabed 
- should now correctly ignore visitors (since visitors are technically members?)
- should now remove data for offline players
@sh0inx sh0inx linked a pull request May 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeachesMLG PeachesMLG

@dlsf dlsf

@MertUnverdi MertUnverdi

Labels
bug Something isn't working high unconfirmed An issue that needs further investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrote clearTeamInventory Iridium-Development/IridiumSkyblock
4 participants
@PeachesMLG @dlsf @MertUnverdi @Micosedeunha