Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect processor architecture used for tests #1837

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Dec 10, 2024

Useful on macOS.

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProcessArchitecture doesn't look like an exact mapping for TargetPlatform, but I guess it sort of works.

Based on docs, if we omit the TargetPlatform tag it'll auto-detect. So might be slightly cleaner to not default platform to anything and omit RunConfiguration if unset?

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slozier slozier merged commit 517c548 into IronLanguages:main Dec 11, 2024
7 of 8 checks passed
@BCSharp BCSharp deleted the process_architecture branch December 11, 2024 17:21
@BCSharp
Copy link
Member Author

BCSharp commented Dec 12, 2024

Hmm, it seems not to work for netcoreapp3.1. I see it is EOL since 2 years. Do you intend to keep it around for longer?

UPDATE: I see that netcoreapp3.1 is simply not available for ARM64.

@slozier
Copy link
Contributor

slozier commented Dec 12, 2024

I'm fine with ditching netcoreapp3.1. Even net6.0 is already out of support. MS is moving a bit too fast for my taste. I was also considering dropping the netstandard2.0 target but maybe too early for that...

@BCSharp
Copy link
Member Author

BCSharp commented Dec 12, 2024

If you are planning to do a release soon, maybe it's worth waiting with the removal till right after the release.

@slozier
Copy link
Contributor

slozier commented Dec 12, 2024

Yes, I do want to release soon. .NET 9 issue has come up a number of times. Anyway, I just need to figure out the .NET tool issue and I can start testing the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants