Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign on loss function #14

Open
johnwlambert opened this issue Apr 16, 2017 · 3 comments
Open

sign on loss function #14

johnwlambert opened this issue Apr 16, 2017 · 3 comments

Comments

@johnwlambert
Copy link

Hi, in the paper pseudocode, for Loss_d and Loss_g, the gradient ascent is turned into gradient descent by making the whole loss negative (negative signs in front of every term).

However, in the code, I don't see any of those negative signs. What am I missing?

Thank you!

@IshmaelBelghazi
Copy link
Owner

The negative term in front of the discriminator loss is factored in the softplus.

@edgarriba
Copy link

@johnwlambert check the expanded formulas

formulas

@edgarriba
Copy link

whereas softplus(x) = log(1 + exp(x))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants