Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discriminator input #6

Open
anantzoid opened this issue Feb 20, 2017 · 1 comment
Open

Discriminator input #6

anantzoid opened this issue Feb 20, 2017 · 1 comment

Comments

@anantzoid
Copy link

In the paper, it's mentioned that the input of discriminator is either joint pairs of q(x~,z) or p(x,z^). However, in the code, it seems (z,z^) and (x,x~) are concatenated and being sent as input to z_discriminator and x_discriminator respectively.

There seems to be a discrepancy here. Please let me know if I'm missing something.

Thanks.

@edgarriba
Copy link

@anantzoid it's then split in https://github.com/IshmaelBelghazi/ALI/blob/master/ali/bricks.py#L50-L51
but yes, overall to me the theano code differs a bit from the described algorithm in the paper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants