Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D render optimization reasearch #135

Closed
HarelM opened this issue Sep 1, 2022 · 1 comment · Fixed by #136
Closed

3D render optimization reasearch #135

HarelM opened this issue Sep 1, 2022 · 1 comment · Fixed by #136
Assignees
@zstadler
Labels
enhancement New feature or request IHM Related to the Israel Hiking Map ILMTB Related to the Israel MTB Map

Comments

@HarelM
Copy link
Member

HarelM commented Sep 1, 2022

It's worth looking into the following optimization of the style when it comes to 3D.
See the following comment:
maplibre/maplibre-gl-js#1368 (comment)
While I'm not suggesting changing the style just yet, considering this improvement might improve the current rendering time (maybe) and worth trying out to see if we can create a style that will allow using the 3D feature (maybe as a new layer and not part of the current layers... just a though, we can discuss this more).
Bottom line, It would be great if we can create a style that doesn't crash our app when using the 3D feature (not to blame anyone for this obviously) :-)
@zstadler zstadler self-assigned this Sep 7, 2022
zstadler referenced this issue Sep 7, 2022
@zstadler
Update IHM.json
7445f5e 
One group for all render-to-texture layers
@zstadler zstadler added enhancement New feature or request IHM Related to the Israel Hiking Map labels Sep 7, 2022
@zstadler zstadler linked a pull request Sep 19, 2022 that will close this issue
3D optimization for IHM #136
Merged
@zstadler zstadler added the ILMTB Related to the Israel MTB Map label Sep 19, 2022
@zstadler zstadler mentioned this issue Sep 19, 2022
Merged
@zstadler
Copy link
Member

ilMTB style is not optimized yet

@zstadler zstadler reopened this Sep 19, 2022
zstadler added a commit that referenced this issue Sep 20, 2022
@zstadler
Optimize ilMTB style for 3D rendering.
425e376 
Related to #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zstadler zstadler

Labels
enhancement New feature or request IHM Related to the Israel Hiking Map ILMTB Related to the Israel MTB Map
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3D optimization for IHM IsraelHikingMap/VectorMap
2 participants
@zstadler @HarelM