Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required_fields regression in 1.5.16 #33

Open
kzemek opened this issue Aug 21, 2024 · 0 comments
Open

required_fields regression in 1.5.16 #33

kzemek opened this issue Aug 21, 2024 · 0 comments

Comments

@kzemek
Copy link

kzemek commented Aug 21, 2024

Environment

  • Elixir version (elixir -v): 1.17.2
  • Domo version (mix deps | grep domo | head -1): 1.5.16

Actual behavior

I'm using the following module definition:

defmodule RequiredTest do
  use Domo
  @enforce_keys [:required]
  defstruct [:required, :optional]
  @type t :: %__MODULE__{required: integer(), optional: integer() | nil}
end

In Domo 1.5.16, RequiredTest.required_fields() returns [:required, :optional], causing downstream problems e.g. for changeset validation.

Expected behavior

RequiredTest.required_fields() should return [:required] like it does in Domo 1.5.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant