Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined method '+' for :Hash #4

Closed
dannysmith opened this issue May 22, 2014 · 10 comments · Fixed by #5
Closed

Undefined method '+' for :Hash #4

dannysmith opened this issue May 22, 2014 · 10 comments · Fixed by #5

Comments

@dannysmith
Copy link
Contributor

I've just tried to use this on a project (with a view to saving me the massive ball-ache of building a SOAP service!) and encountered this error:

screen shot 2014-05-22 at 23 59 21

A clean project with this:

require 'sinatra/base'
require 'sinatra/soap'

class SoapAPI < Sinatra::Base

  #remember to register extenstion if you are using modular style
  register Sinatra::Soap

  soap :test, in: { thing: :string }, out: nil do
    {thing: "My thing"}
  end
end

yields the same error. All the tests seem to pass, and I haven't got time to dig any deeper right now.

What's formats[:in] + formats[:out] supposed to do to the hashes? I'm afraid I'm not very well versed in builder's DSL.

@IvanShamatov
Copy link
Owner

Danny currently project have some issues and tests fail. I will try to help you in a day, check it tomorrow?

@dannysmith
Copy link
Contributor Author

Thanks - if you haven't got the time to work on this, could you point me to the failing tests and I can fork and fix.

@shiftux
Copy link

shiftux commented May 2, 2016

This is still not fixed in the gem.
adding this line to my Gemfile worked for me:
gem 'sinatra-soap', github: 'IvanShamatov/sinatra-soap'
hth

@dannysmith
Copy link
Contributor Author

@shiftux I never bumped the version number in #5. You could bump it yourself and ask @IvanShamatov to merge and push a new release to RubyGems.

@IvanShamatov
Copy link
Owner

@shiftux sure, I can do that.
By the way, are you sure it is implemented in gem already? Cause I worked on documentation but I hardly spent some time to implement all this stuff inside.
@dannysmith @shiftux Guys, there is no problem to transfer this gem to anyone of you, if you agree to complete it.

@dannysmith
Copy link
Contributor Author

dannysmith commented May 2, 2016

The last commit on here is when you merged #5 back in 2014. The latest version on rubygems is from Dec 2013. More than happy to bump the version number and push a new release to rubygems if you transfer it to me on both, but I can't really commit to maintaining it properly since I don't know much about SOAP! @IvanShamatov let me know what you want to do.

@IvanShamatov
Copy link
Owner

@dannysmith just make a pull request, I will push it to rubygems, if it works

@IvanShamatov
Copy link
Owner

@dannysmith And thanks for help.

@dannysmith
Copy link
Contributor Author

Cool. I'll raise a PR for the version number tomorrow, which will also close #6.

@IvanShamatov Do you want me to include this commit (which is unrelated)?

@shiftux
Copy link

shiftux commented May 3, 2016

thanks to both of you @dannysmith, @IvanShamatov
i am not at all versed in the use of SOAP, i would not feel comfortable taking over this gem
but happy to help if i can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants