Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Loan Section feature #2740

Closed
1 task done
arnavarya89 opened this issue Oct 2, 2023 · 18 comments · Fixed by #2928
Closed
1 task done

Loan Section feature #2740

arnavarya89 opened this issue Oct 2, 2023 · 18 comments · Fixed by #2928
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev feature New functionality to be added good first issue Good for newcomers keep Keep it from automatically getting closed by Stale P0 Critical and urgent user request Feature/improvement requested by an user

Comments

@arnavarya89
Copy link

arnavarya89 commented Oct 2, 2023

Please confirm the following

What would you like to improve?

In the Loan Option Suppose I lend a loan or money to a person with Reason X then I again gave money to the same person with reason Y and many times. So instead of adding a loan many times can't we do that in the add record button we again add some money as lent with both reason X and Y visible on it will be more clean to see it and easy to maintain records and for the borrowed part

Because...

It would be easier for all users to maintain their records more conveniently

Description

No response

Success Criteria

_add a option in add record option to like increase debit with a reason for loan just a same as the features to receive money we just to do it with increase debt.

@ILIYANGERMANOV ILIYANGERMANOV added feature New functionality to be added user request Feature/improvement requested by an user approved Approved by the Ivy Wallet team. Ready for dev labels Oct 2, 2023
@nvllz
Copy link
Contributor

nvllz commented Oct 2, 2023

On the one hand, it's a good idea, but I think it will require a complete change in the way the application handles loan records. There are so many things to work on now, so until it's finally done, you could try to develop a naming strategy for the loans.

What about the loan description feature?
You could name each loan like "2023-10 Emily" with a short description, like in transactions. Descriptions combined with loan archiving would be a more real thing you could expect in the near future, and this might meet your needs.

@arnavarya89
Copy link
Author

arnavarya89 commented Oct 2, 2023 via email

@nvllz
Copy link
Contributor

nvllz commented Oct 2, 2023

Oh, I get it now. This may be easier than I first thought. The problem is with the 'add record' option. Instead of just making it a 'someone gives you money back', add a switch (like in the transaction where you can easily toggle between income/expense) that would allow an additional borrowing event to be logged and added to the total debt amount of the loan entry.

Example:

  • User logs a loan event, names it "Emily", and sets the debt amount to 200 USD
  • Emily repaid $10 the next day, so the user adds a record that makes the total debt $190
  • Emily borrowed an additional $100 from the Ivy Wallet user, so the user can add a record that makes the total debt $290 ($200-$10+$100)

This way the user could track the loans in an efficient way, and I don't think it would be that hard to do. Just make the records to be income/expense events, and apply them to the loan type (borrow/lend).

@arnavarya89
Copy link
Author

arnavarya89 commented Oct 2, 2023 via email

@nvllz
Copy link
Contributor

nvllz commented Oct 4, 2023

All you can do is make two different loan entries and split the money received in two transactions between those loans.

We need some more advanced people to rate the difficulty of the feature I described above, and any volunteers to come up with it. I hope I helped you to make the feature request clearer.

@vartult
Copy link
Contributor

vartult commented Oct 6, 2023

Hey @nvllz, correct me if I'm wrong, we can easily update the total borrowed amount by updating the master borrowed amount, like in the example you took we can basically update the amount to 290USD. Though this won't create an entry for the txn but acknowledge the usecase OP wants. We can then track owed money repayment by adding records. Though we can give an option while updating the master borrowed amount to create a separate entry for this amount update.

@nvllz
Copy link
Contributor

nvllz commented Oct 6, 2023

Yeah, youre right. But to keep track of the money flow it would be cool to have an income/expense scheme in loans section. You can get unsure after some time if you do not have a clear record with transaction date, time and description.

@arnavarya89
Copy link
Author

arnavarya89 commented Oct 6, 2023 via email

@vartult
Copy link
Contributor

vartult commented Oct 6, 2023

Sure, @arnavarya89 do you have a solution to this? or I can brainstorm around it and impl.

@arnavarya89
Copy link
Author

arnavarya89 commented Oct 6, 2023 via email

@arnavarya89
Copy link
Author

arnavarya89 commented Oct 13, 2023 via email

@ILIYANGERMANOV
Copy link
Collaborator

It's unassigned if anyone wants to take it

@github-actions github-actions bot added the Stale No activity, will be automatically closed soon. label Nov 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
@RDjarbeng
Copy link

I was about to place a feature request for this, but someone else already has that problem. Is there a way to upvote this or something to make the devs know that other users are also interested?

@github-actions github-actions bot removed the Stale No activity, will be automatically closed soon. label Jan 23, 2024
@ILIYANGERMANOV ILIYANGERMANOV added the good first issue Good for newcomers label Jan 28, 2024
@ILIYANGERMANOV
Copy link
Collaborator

I was about to place a feature request for this, but someone else already has that problem. Is there a way to upvote this or something to make the devs know that other users are also interested?

Hey @RDjarbeng we don't have an upvote mechanism - maybe just react with 👍

@RDjarbeng
Copy link

Alright, noted. Looking forward to this feature. Thank you for building this app too

@michalguspiel
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @michalguspiel! 🎉
Issue #2740 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@ILIYANGERMANOV ILIYANGERMANOV added keep Keep it from automatically getting closed by Stale P0 Critical and urgent labels Feb 6, 2024
@michalguspiel michalguspiel mentioned this issue Feb 7, 2024
5 tasks
@RDjarbeng
Copy link

Thank you so much. Will this be available on the Google Play Store now or we have to wait for an update?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev feature New functionality to be added good first issue Good for newcomers keep Keep it from automatically getting closed by Stale P0 Critical and urgent user request Feature/improvement requested by an user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants