Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Implement FakeTransactionDao #2933

Closed
1 task done
ILIYANGERMANOV opened this issue Feb 8, 2024 · 5 comments · Fixed by #2959
Closed
1 task done

Implement FakeTransactionDao #2933

ILIYANGERMANOV opened this issue Feb 8, 2024 · 5 comments · Fixed by #2959
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience good first issue Good for newcomers help wanted Help us! Appreciated P2 Nice to have tests Write UI, Unit or Instrumented test cases

Comments

@ILIYANGERMANOV
Copy link
Collaborator

ILIYANGERMANOV commented Feb 8, 2024

Please confirm the following

What would you like to improve?

Implement the FakeTransactionDao to mirror 1:1 the real behavior of TransactionDao and WriteTransactionDao.

Because...

  • Enable use of the TransactionRepository in Unit tests.

Description

  1. Implement the methods in the fake dao.
  2. Look at the real SQL queries and try to mirror the behavior.
  3. Cover the fake dao with unit tests.

Success Criteria

  • The fake dao is implemented and behaves like the real SQL dao.
  • The fake dao is covered with unit tests.
@ILIYANGERMANOV ILIYANGERMANOV added devexp Codebase & dev experience good first issue Good for newcomers help wanted Help us! Appreciated tests Write UI, Unit or Instrumented test cases approved Approved by the Ivy Wallet team. Ready for dev P2 Nice to have labels Feb 8, 2024
@ivywallet
Copy link
Collaborator

Thank you @ILIYANGERMANOV for raising Issue #2933! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV changed the title Implement FakeTranssctionDao Implement FakeTransactionDao Feb 9, 2024
@Rick-AB
Copy link
Contributor

Rick-AB commented Feb 13, 2024

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @Rick-AB! 🎉
Issue #2933 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@AMHaroun
Copy link
Contributor

Hey @Rick-AB do you mind if I take over this issue? I'd like to get more experience writing tests. If you've already done some work please don't hesitate to say no.

@Rick-AB
Copy link
Contributor

Rick-AB commented Feb 14, 2024

Hi @AMHaroun I'm already finished with the tests, but I'm sure you can pick up whichever one comes up next

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience good first issue Good for newcomers help wanted Help us! Appreciated P2 Nice to have tests Write UI, Unit or Instrumented test cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants