Skip to content

Commit

Permalink
Forwarding error may cause request not found in request processor pen…
Browse files Browse the repository at this point in the history
…ding queue
  • Loading branch information
JackyWoo committed Feb 29, 2024
1 parent 497d274 commit a4e0589
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/Service/RequestProcessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ bool RequestProcessor::shouldProcessCommittedRequest(const RequestForSession & c
found_in_pending_queue = false;
LOG_WARNING(
this->log,
"Not found committed(write) request {} in pending queue. Possible reason: 1.close requests from deadSessionCleanThread are not put "
"into pending queue; 2.error occurs(because of forward or append entries) but request is still committed, "
"Not found committed(write) request {} in pending queue. Possible reason: 1.close requests from deadSessionCleanThread are not "
"put into pending queue; 2.error occurs(because of forward or append entries) but request is still committed, "
"'processErrorRequest' may delete request from pending request first, so here we can not find it.",
committed_request.toSimpleString());
};
Expand Down Expand Up @@ -349,10 +349,10 @@ void RequestProcessor::processErrorRequest(size_t count)
{
LOG_WARNING(
this->log,
"Not found error request {} in pending queue. Possible reason: 1.close requests from deadSessionCleanThread are not put "
"into pending queue; 2.error occurs(forward or append entries) but request is still committed, "
"'processCommittedRequest' may delete request from pending request first, so here we can not find it. We also delete "
"it from errors.",
"Not found error request {} in pending queue. Possible reason: 1. request forwarding error; 2.close requests from "
"deadSessionCleanThread are not put into pending queue; 3.error occurs(forward or append entries) but request is still "
"committed, 'processCommittedRequest' may delete request from pending request first, so here we can not find it. We "
"also delete it from errors.",
error_request.toString());

error_request_ids.erase(error_request.getRequestId());
Expand Down

0 comments on commit a4e0589

Please sign in to comment.