Inline method push_back for compact string

JDRaftKeeper · Jun 12, 2024 · ee43104 · ee43104
1 parent dcaa2ad
commit ee43104
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 17 deletions.
diff --git a/src/Common/CompactStrings.cpp b/src/Common/CompactStrings.cpp
@@ -1,6 +1,4 @@
-#include "CompactStrings.h"
-
-#include "Service/memcopy.h"
+#include <Common/CompactStrings.h>
 
 
 namespace RK
@@ -24,17 +22,6 @@ void CompactStrings::reserve(size_t n, size_t total_size_)
         data.reserve(AVG_ELEMENT_SIZE_HINT * total_size_);
 }
 
-void CompactStrings::push_back(const String & s)
-{
-    const size_t old_size = data.size();
-    const size_t size_to_append = s.size();
-    const size_t new_size = old_size + size_to_append;
-
-    data.resize(new_size);
-    memcopy(data.data() + old_size, s.c_str(), size_to_append);
-    offsets.push_back(new_size);
-}
-
 StringRef CompactStrings::operator[](int64_t i) const
 {
     return StringRef(&data[offsets[i - 1]], offsets[i] - offsets[i - 1]);

diff --git a/src/Common/CompactStrings.h b/src/Common/CompactStrings.h
@@ -1,7 +1,8 @@
 #pragma once
 
-#include "PODArray.h"
-#include "common/StringRef.h"
+#include <Common/PODArray.h>
+#include <Service/memcopy.h>
+#include <common/StringRef.h>
 
 
 namespace RK
@@ -48,7 +49,17 @@ class CompactStrings
 
     void reserve(size_t n, size_t total_size = 0);
 
-    void push_back(const String & s);
+    inline void push_back(const String & s)
+    {
+        const size_t old_size = data.size();
+        const size_t size_to_append = s.size();
+        const size_t new_size = old_size + size_to_append;
+
+        data.resize(new_size);
+        memcopy(data.data() + old_size, s.c_str(), size_to_append);
+        offsets.push_back(new_size);
+    }
+
     template <class Ttr> void push_back(Ttr begin, Ttr end)
     {
         for (Ttr it = begin; it != end; ++it)