add cluster_config_lock_ to avoid data race #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2023.11.16 07:56:43.746655 [ 125 ] <Trace> ForwardingConnectionHandler: Forwarding handler socket readable
2023.11.16 07:56:43.746676 [ 125 ] <Trace> ForwardingConnectionHandler: forwarding handler socket available
2023.11.16 07:56:43.746689 [ 125 ] <Trace> ForwardingConnectionHandler: Try handle new package
2023.11.16 07:56:43.746708 [ 125 ] <Trace> ForwardingConnectionHandler: Receive Handshake
2023.11.16 07:56:43.746725 [ 125 ] <Trace> ForwardingConnectionHandler: forwarding handler socket available
2023.11.16 07:56:43.746898 [ 125 ] <Fatal> : Logical error: 'Server 2 client 9 already registered in dispatcher'.
2023.11.16 07:56:43.747143 [ 11 ] <Trace> BaseDaemon: Received signal 6
2023.11.16 07:56:43.747447 [ 130 ] <Fatal> BaseDaemon: ########################################
2023.11.16 07:56:43.747523 [ 130 ] <Fatal> BaseDaemon: (version v2.0.3, build id: 542805F1020432FC) (from thread 125) Received signal Aborted (6)
2023.11.16 07:56:43.747585 [ 130 ] <Fatal> BaseDaemon:
2023.11.16 07:56:43.747677 [ 130 ] <Fatal> BaseDaemon: Stack trace: 0x7f793d529a7c 0x7f793d4d5476 0x7f793d4bb7f3 0x7fecde 0x7ff1d4 0xad9f59 0xac9e16 0xa5a555 0xa52f79 0xa6145d 0x1655184 0x9aaad0 0x9995f9 0x991dd9 0x1750429 0x174c652 0x7f793d527b43 0x7f793d5b8bb4./runner --tsan-options='report_thread_leaks=0:detect_deadlocks=0:halt_on_error=1:history_size=7' "test_forward_expiration" |
JackyWoo
reviewed
Nov 17, 2023
|
The error may not caulsed by your changing, I will take a look at it latter. |
|
@lzydmxy please rebase the recent master branch |
|
Mark the error test |
okay |
closed in #110 |
lzydmxy
force-pushed
the
add_mutex_for_cur_cluster_config
branch
from
4a8e6df to
fd04a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues of this PR fixes:
This PR try to fix #104
Change log:
add cluster_config_lock_ to avoid data race