Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too much warning log #109

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix too much warning log #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Service/ConnectionHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,6 @@ void ConnectionHandler::sendResponse(const Coordination::ZooKeeperResponsePtr &
{
LOG_TRACE(log, "Dispatch response {} to conn handler session {}", response->toString(), toHexString(session_id));

/// TODO should invoked after response sent to client.
updateStats(response);

/// We do not need send anything for close request to client.
Expand Down
8 changes: 1 addition & 7 deletions src/Service/RequestProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,12 +195,6 @@ void RequestProcessor::processCommittedRequest(size_t count)
my_pending_requests.erase(committed_request.session_id);
}

LOG_WARNING(
log,
"Session {} is not local, maybe it is because of disconnecting. We still should apply the committed(write) "
"request",
committed_request.session_id);

applyRequest(committed_request);
committed_queue.pop();
}
Expand All @@ -209,7 +203,7 @@ void RequestProcessor::processCommittedRequest(size_t count)
{
if (committed_request.request->getOpNum() == Coordination::OpNum::Auth)
{
LOG_DEBUG(log, "Apply auth request", committed_request.session_id);
LOG_DEBUG(log, "Apply auth request {}", toHexString(committed_request.session_id));
applyRequest(committed_request);
committed_queue.pop();
}
Expand Down