Save term info in snapshot filename #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, except some code styles |
|
Please remove RaftKeeper/src/Service/SnapshotCommon.h Line 47 in f6dc73d |
JackyWoo
reviewed
Jun 5, 2024
src/Service/NuRaftLogSnapshot.cpp
Outdated
| #include <fcntl.h> | ||
| #include <filesystem> | ||
| #include <stdio.h> | ||
| #include <unistd.h> | ||
|
|
||
| #include "common/find_symbols.h" |
src/Service/NuRaftLogSnapshot.cpp
Outdated
| continue; | ||
| } | ||
|
|
||
| auto key = static_cast<uint128_t>(s_obj.log_last_term) << 64 | s_obj.log_last_index; |
There was a problem hiding this comment.
Use getSnapshotStoreMapKey
src/Service/NuRaftLogSnapshot.h
Outdated
| /// create_time, last_log_term, last_log_index, object_id | ||
| static constexpr char SNAPSHOT_FILE_NAME_V1[] = "snapshot_{}_{}_{}_{}"; | ||
|
|
||
| String time_str; |
JackyWoo
approved these changes
Jun 5, 2024
lzydmxy
force-pushed
the
add_term_info_for_snapshot
branch
from
c2fc175 to
bef2a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues of this PR fixes:
This PR try to fix #4
Change log:
update SNAPSHOT_FILE_NAME from snapshot_{create_time}{last_log_index}{object_id} to snapshot_{create_time}{last_log_term}{last_log_index}_{object_id}